Recompute TTL values on each get
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTL values must be recomputed on each `get` action instead of being fixed to a constant value for the lifetime of the cached object. Prior to this change, the constant TTL value `X` would cause kafka-connect to continually reschedule connector restarts `X` milliseconds in the future, effectively ensuring that the connector never actually restarts. With this change, the reschedule actions have a timestamp that shrinks until the TTL is reached. Before (note contant restart time of ~30 mins): ``` 2021-12-03 20:19:65,634 INFO || Scheduling a restart of connector debezium_infra in 1799900 ms [org.apache.kafka.connect.runtime.WorkerConfigTransformer] 2021-12-03 20:18:25,143 INFO || Scheduling a restart of connector debezium_infra in 1799900 ms [org.apache.kafka.connect.runtime.WorkerConfigTransformer] ``` After (note restart time decreases ~40 seconds and the log messages are ~40 seconds apart): ``` 2021-12-03 21:09:24,228 INFO || Scheduling a restart of connector debezium_infra in 2063263 ms [org.apache.kafka.connect.runtime.WorkerConfigTransformer] 2021-12-03 21:08:45,858 INFO || Scheduling a restart of connector debezium_infra in 2101945 ms [org.apache.kafka.connect.runtime.WorkerConfigTransformer] ``` Fix build issues with Azure tests Set the TTL to `None` if the duration is `0`
andrewstevenson
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of the Azure segments of #34 by @kppullin-nt against the latest codebase.
The original description follows.
TTL values must be recomputed on each
getaction instead of being fixed to a constant value for the lifetime of the cached object.Prior to this change, the constant TTL value
Xwould cause kafka-connect to continually reschedule connector restartsXmilliseconds in the future, effectively ensuring that the connector never actually restarts.With this change, the reschedule actions have a timestamp that shrinks until the TTL is reached.
Before (note contant restart time of ~30 mins):
After (note restart time decreases ~40 seconds and the log messages are ~40 seconds apart):
Fix build issues with Azure tests
Set the TTL to
Noneif the duration is0